Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1294: Fixed deprecated RequestStack::getMasterRequest usages #18

Merged
merged 1 commit into from
Nov 28, 2022
Merged

IBX-1294: Fixed deprecated RequestStack::getMasterRequest usages #18

merged 1 commit into from
Nov 28, 2022
+1 −1

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 25, 2022 •
edited
Loading

JIRA: IBX-1294

Description

\Symfony\Component\HttpFoundation\RequestStack::getMasterRequest method is deprecated since SF 5.3 and should be replaced by getMainRequest

Checklist

  • Code follows the code style of this project (use $ composer fix-cs).
  • Change requires a change to the documentation.
  • Code is ready for a review.

@alongosz
Copy link
Member

Sonar issues are valid, but unrelated.

@alongosz
Copy link
Member

@adamwojs do we need QA on this?

@adamwojs
Copy link
Member Author

@alongosz IMHO only sanities

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 1353d42 into main Nov 28, 2022
@adamwojs adamwojs deleted the ibx_1294 branch November 28, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

Assignees

@alongosz alongosz

@konradoboza konradoboza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @alongosz @mikadamczyk @konradoboza @katarzynazawada